danny0405 commented on code in PR #17779:
URL: https://github.com/apache/hudi/pull/17779#discussion_r2660635493
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/timeline/versioning/v2/TimelineArchiverV2.java:
##########
@@ -125,6 +123,10 @@ public int archiveIfRequired(HoodieEngineContext context,
boolean acquireLock) t
} else {
log.info("No Instants to archive");
}
+ // run compact and clean if needed even no instants were archived
+ if (!instantsToArchive.isEmpty() || config.isTimelineCompactionForced())
{
Review Comment:
The current compaction strategy is kind of eager(compact all the layers
casecadingly) when a new archived file is generated, so even if we trigger
compaction for commits that does not archive, it does not take effect as
expected at all.
Wondering wheter we could introduce some lazy compaction strategies or add a
upper threshold for the target file size of single round of compaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
