qukaikai123 commented on PR #17806: URL: https://github.com/apache/hudi/pull/17806#issuecomment-3723682103
> Thank you for the triaging the rootcause for this. > > Do you think it's better if we remove the `HoodieTableMetaClient.newTableBuilder().initTable()` from clear()? > > Regardless, i feel the better fix will be to refactor `HiveTestUtil` to use JUnit's `@TempDir` like `HiveSyncFunctionalTestHarness` does, eliminating manual directory management entirely. Thank you for your insightful feedback! You're absolutely right – removing HoodieTableMetaClient.newTableBuilder().initTable() from the clear() method is a much better approach. I've checked all the classes that use this method, and confirmed that removing it has no adverse impact on the functionality. Moreover, the clear() method was never intended to contain this logic in the first place, so I've already made the corresponding changes to remove it. I fully agree with your suggestion to refactor HiveTestUtil to use JUnit's https://github.com/tempdir (just like HiveSyncFunctionalTestHarness does) – this is definitely the most appropriate solution as it would completely eliminate the need for manual directory management. I plan to work on this refactoring when I have spare time in the follow-up. Thanks again for your thorough review and valuable suggestions! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
