danny0405 commented on code in PR #17797:
URL: https://github.com/apache/hudi/pull/17797#discussion_r2674762334
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -625,7 +625,8 @@ public static <R> HoodieData<HoodieRecord<R>>
tagGlobalLocationBackToRecords(
boolean isCommitTimeOrdered = readerContext.getMergeMode() ==
RecordMergeMode.COMMIT_TIME_ORDERING;
// if the index is not updating the partition of the record, and the table
is COW, then we do not need to do merging at
// this phase since the writer path will merge when rewriting the files as
part of the upsert operation.
- boolean requiresMergingWithOlderRecordVersion = shouldUpdatePartitionPath
|| table.getMetaClient().getTableConfig().getTableType() ==
HoodieTableType.MERGE_ON_READ;
+ boolean requiresMergingWithOlderRecordVersion = shouldUpdatePartitionPath
+ || (!isCommitTimeOrdered &&
table.getMetaClient().getTableConfig().getTableType() ==
HoodieTableType.MERGE_ON_READ);
Review Comment:
nice catch~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
