danny0405 commented on code in PR #17803:
URL: https://github.com/apache/hudi/pull/17803#discussion_r2674806918
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableFactory.java:
##########
@@ -181,9 +183,14 @@ private void sanityCheck(Configuration conf,
ResolvedSchema schema) {
* Validate the index type.
*/
private void checkIndexType(Configuration conf) {
- String indexType = conf.get(FlinkOptions.INDEX_TYPE);
- if (!StringUtils.isNullOrEmpty(indexType)) {
- HoodieIndexConfig.INDEX_TYPE.checkValues(indexType);
+ String indexTypeStr = conf.get(FlinkOptions.INDEX_TYPE);
Review Comment:
need to add a test in `TestHoodieTableFactory`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
