HuangZhenQiu commented on code in PR #13892:
URL: https://github.com/apache/hudi/pull/13892#discussion_r2679264859


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/append/AppendWriteFunctionWithBufferSort.java:
##########
@@ -155,4 +225,16 @@ private void sortAndSend() throws IOException {
   private static void sort(BinaryInMemorySortBuffer dataBuffer) {
     new QuickSort().sort(dataBuffer);
   }
+
+  @Override
+  public void close() throws Exception {
+    try {
+      waitForAsyncWriteCompletion();

Review Comment:
   Yes, you are right. If it close due to exception, checkpoint will not 
complete. Data will be reprocessed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to