danny0405 commented on code in PR #17821:
URL: https://github.com/apache/hudi/pull/17821#discussion_r2684653483
##########
hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/commit/DatasetBulkInsertOverwriteCommitActionExecutor.java:
##########
@@ -69,6 +70,11 @@ protected Map<String, List<String>>
getPartitionToReplacedFileIds(HoodieData<Wri
table.getContext().setJobStatus(this.getClass().getSimpleName(),
"Getting ExistingFileIds of matching static partitions");
return
HoodieJavaPairRDD.getJavaPairRDD(table.getContext().parallelize(partitionPaths,
partitionPaths.size()).mapToPair(
partitionPath -> Pair.of(partitionPath,
getAllExistingFileIds(partitionPath)))).collectAsMap();
+ } else if (!table.isPartitioned()) {
+ // Do not need to check for partition paths for non-partitioned tables
+ Map<String, List<String>> result = new HashMap<>();
Review Comment:
you mean to save the cost of this line:
`HoodieJavaPairRDD.getJavaPairRDD(writeStatuses.map` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
