yihua commented on code in PR #17659:
URL: https://github.com/apache/hudi/pull/17659#discussion_r2691744953
##########
hudi-common/src/main/java/org/apache/hudi/common/schema/HoodieSchemaUtils.java:
##########
@@ -794,4 +795,50 @@ public static String addMetadataColumnTypes(String
hiveColumnTypes) {
public static boolean isMetadataField(String fieldName) {
return HoodieRecord.HOODIE_META_COLUMNS_WITH_OPERATION.contains(fieldName);
}
+
+ /**
+ * Converts a HoodieSchemaField's default value to its Java representation.
+ * This is equivalent to {@link
org.apache.hudi.avro.HoodieAvroUtils#toJavaDefaultValue(org.apache.avro.Schema.Field)}
+ * but operates on HoodieSchemaField.
+ *
+ * <p>For primitive types (STRING, INT, LONG, FLOAT, DOUBLE, BOOLEAN, ENUM,
BYTES),
+ * the default value is returned as-is. For complex types (ARRAY, MAP,
RECORD),
+ * Avro's GenericData utility is used to properly construct the default
value.</p>
+ *
+ * @param field the HoodieSchemaField containing the default value
+ * @return the Java representation of the default value, or null if no
default value exists
+ * @throws IllegalArgumentException if the field's type is not supported
+ * @since 1.2.0
+ */
+ public static Object toJavaDefaultValue(HoodieSchemaField field) {
+ ValidationUtils.checkArgument(field != null, "Field cannot be null");
+
+ Option<Object> defaultValOpt = field.defaultVal();
+ if (!defaultValOpt.isPresent() || defaultValOpt.get() ==
HoodieJsonProperties.NULL_VALUE) {
+ return null;
+ }
+
+ Object defaultVal = defaultValOpt.get();
+ HoodieSchemaType type = field.getNonNullSchema().getType();
+
+ switch (type) {
Review Comment:
This does not cover `FIXED`, `DECIMAL`, `TIME`, `TIMESTAMP`, `DATE`, and
`UUID`. Should they be included?
##########
hudi-common/src/main/java/org/apache/hudi/common/schema/HoodieSchemaUtils.java:
##########
@@ -794,4 +795,50 @@ public static String addMetadataColumnTypes(String
hiveColumnTypes) {
public static boolean isMetadataField(String fieldName) {
return HoodieRecord.HOODIE_META_COLUMNS_WITH_OPERATION.contains(fieldName);
}
+
+ /**
+ * Converts a HoodieSchemaField's default value to its Java representation.
+ * This is equivalent to {@link
org.apache.hudi.avro.HoodieAvroUtils#toJavaDefaultValue(org.apache.avro.Schema.Field)}
+ * but operates on HoodieSchemaField.
+ *
+ * <p>For primitive types (STRING, INT, LONG, FLOAT, DOUBLE, BOOLEAN, ENUM,
BYTES),
+ * the default value is returned as-is. For complex types (ARRAY, MAP,
RECORD),
+ * Avro's GenericData utility is used to properly construct the default
value.</p>
+ *
+ * @param field the HoodieSchemaField containing the default value
+ * @return the Java representation of the default value, or null if no
default value exists
+ * @throws IllegalArgumentException if the field's type is not supported
+ * @since 1.2.0
+ */
+ public static Object toJavaDefaultValue(HoodieSchemaField field) {
+ ValidationUtils.checkArgument(field != null, "Field cannot be null");
+
+ Option<Object> defaultValOpt = field.defaultVal();
+ if (!defaultValOpt.isPresent() || defaultValOpt.get() ==
HoodieJsonProperties.NULL_VALUE) {
+ return null;
+ }
+
+ Object defaultVal = defaultValOpt.get();
+ HoodieSchemaType type = field.getNonNullSchema().getType();
+
+ switch (type) {
Review Comment:
I'm OK to land this PR first to unblock other PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
