majian1998 commented on code in PR #17841:
URL: https://github.com/apache/hudi/pull/17841#discussion_r2692737941
##########
packaging/hudi-presto-bundle/pom.xml:
##########
@@ -104,11 +104,6 @@
<pattern>org.objenesis.</pattern>
<shadedPattern>org.apache.hudi.org.objenesis.</shadedPattern>
</relocation>
-
- <relocation>
- <pattern>org.apache.parquet.avro.</pattern>
-
<shadedPattern>org.apache.hudi.org.apache.parquet.avro.</shadedPattern>
Review Comment:
In our build, `presto.bundle.bootstrap.shade.prefix` defaults to
`org.apache.hudi.`. With that value, the two relocations for
`org.apache.parquet.avro.*` are effectively identical:
- org.apache.parquet.avro.* -> org.apache.hudi.org.apache.parquet.avro.*
- org.apache.parquet.avro.* ->
${presto.bundle.bootstrap.shade.prefix}org.apache.parquet.avro.* (=>
org.apache.hudi.org.apache.parquet.avro.*)
So keeping both does not change shading scope/behavior; it is redundant and
potentially confusing. This PR removes the hard-coded duplicate and keeps the
prefix-based relocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
