linliu-code commented on code in PR #14319:
URL: https://github.com/apache/hudi/pull/14319#discussion_r2700344211
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/TransactionManager.java:
##########
@@ -43,14 +43,19 @@ public class TransactionManager implements Serializable {
private Option<HoodieInstant> lastCompletedTxnOwnerInstant = Option.empty();
public TransactionManager(HoodieWriteConfig config, HoodieStorage storage) {
- this(new LockManager(config, (FileSystem) storage.getFileSystem()),
config.isLockRequired());
+ this(createLockManager(config, (FileSystem) storage.getFileSystem()),
config.isLockRequired());
}
protected TransactionManager(LockManager lockManager, boolean
isLockRequired) {
this.lockManager = lockManager;
this.isLockRequired = isLockRequired;
}
+ static LockManager createLockManager(HoodieWriteConfig config, FileSystem
fs) {
+ fs.getConf().addResource(fs.getConf());
Review Comment:
I verified locally, this line does not do anything meaningful. Therefore, I
will remove this line.
CC: @ad1happy2go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
