voonhous commented on code in PR #17911:
URL: https://github.com/apache/hudi/pull/17911#discussion_r2700653954


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -719,28 +686,19 @@ static void 
validateEligibilityForSecondaryOrExpressionIndex(HoodieTableMetaClie
     String columnName = sourceFields.get(0); // We know there's only one 
column from the check above

Review Comment:
   Not sure why the previous function was written to accept a list, but i felt 
that it was unnecessary circular and overly complex, so i simplified it given 
that it was only called within `HoodieIndexUtils` and not outside of it. So, i 
don't think there's any risk to simplify it to inspect a singular field.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to