voonhous opened a new pull request, #17948:
URL: https://github.com/apache/hudi/pull/17948
### Describe the issue this Pull Request addresses
<!-- Either describe the issue inline here with motivation behind the
changes
(or) link to an issue by including `Closes #<issue-number>` for
context.
If this PR includes changes to the storage format, public APIs,
or has breaking changes, use `!` (e.g., feat!: ...) -->
Building docker images is quite painful where we have to modify each of the
versions within the docker files previously for all image.
Since we have `build_docker_images.sh` that is the common entrypoint for
helping build these images, we should also allow the versions specified in
these scripts to be pushed down to the docker files.
On top of that, they shouldn't be hardcoded in files too. We can make the
hardcoded versions defaults, but the script should be able to allow command
line arguments to be passed into it.
On top of that, we have changed the base version of java to java11 since we
have moved to java11.
We can now use the script as such:
```shell
./build_docker_images.sh [--hadoop-version <version>] [--spark-version
<version>] [--hive-version <version>] [--version-tag <tag>]
```
### Summary and Changelog
<!-- Short, plain-English summary of what users gain or what changed in
behavior.
Followed by a detailed log of all the changes. Highlight if any code
was copied. -->
1. Bumped base java version to 11
2. Allow versions specified `build_docker_images.sh` to be pushed down to
docker files
3. Allow auto resolving of hudi project version via main pom file as image
tag version
4. Allow users to specify image tag version explicitly
5. Allow users to specify HADOOP, SPARK, HIVE version via CLI
### Impact
<!-- Describe any public API or user-facing feature change or any
performance impact. -->
Better developer experience for building docker images without having to
trudge through dockerfiles.
### Risk Level
<!-- Accepted values: none, low, medium or high. Other than `none`, explain
the risk.
If medium or high, explain what verification was done to mitigate the
risks. -->
None, no code changes, everything done here is tooling related
### Documentation Update
<!-- Describe any necessary documentation update if there is any new
feature, config, or user-facing change. If not, put "none".
- The config description must be updated if new configs are added or the
default value of the configs are changed.
- Any new feature or user-facing change requires updating the Hudi website.
Please follow the
[instruction](https://hudi.apache.org/contribute/developer-setup#website)
to make changes to the website. -->
We will address usage of this script's documentation later.
### Contributor's checklist
- [X] Read through [contributor's
guide](https://hudi.apache.org/contribute/how-to-contribute)
- [X] Enough context is provided in the sections above
- [X] Adequate tests were added if applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
