This is an automated email from the ASF dual-hosted git repository.
vhs pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git
The following commit(s) were added to refs/heads/master by this push:
new a55bc00f8e70 fix: Fix TestBucketizedBloomCheckPartitioner
assertArrayEquals comparison (#17888)
a55bc00f8e70 is described below
commit a55bc00f8e7097a18bd6ecb82470e6576e4edaf0
Author: voonhous <[email protected]>
AuthorDate: Mon Jan 19 19:01:18 2026 +0800
fix: Fix TestBucketizedBloomCheckPartitioner assertArrayEquals comparison
(#17888)
---
.../hudi/index/bloom/BucketizedBloomCheckPartitioner.java | 12 ++++++++----
.../index/bloom/TestBucketizedBloomCheckPartitioner.java | 5 +++--
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git
a/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/bloom/BucketizedBloomCheckPartitioner.java
b/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/bloom/BucketizedBloomCheckPartitioner.java
index 1a55f799d573..142940d42556 100644
---
a/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/bloom/BucketizedBloomCheckPartitioner.java
+++
b/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/index/bloom/BucketizedBloomCheckPartitioner.java
@@ -60,7 +60,7 @@ import scala.Tuple2;
@Slf4j
public class BucketizedBloomCheckPartitioner extends Partitioner {
- private int partitions;
+ private final int partitions;
/**
* Stores the final mapping of a file group to a list of partitions for its
keys.
@@ -149,12 +149,16 @@ public class BucketizedBloomCheckPartitioner extends
Partitioner {
}
if (log.isDebugEnabled()) {
- log.debug("Partitions assigned per file groups :" +
fileGroupToPartitions);
+ log.debug("Partitions assigned per file group: {}",
fileGroupToPartitions);
StringBuilder str = new StringBuilder();
for (int i = 0; i < bucketsFilled.length; i++) {
- str.append("p" + i + " : " + bucketsFilled[i] + ",");
+ str.append("{p").append(i).append(":
").append(bucketsFilled[i]).append("}, ");
}
- log.debug("Num buckets assigned per file group :" + str);
+ // Strip last ", " away
+ if (bucketsFilled.length > 0) {
+ str.setLength(str.length() - 2);
+ }
+ log.debug("Num buckets assigned per partition: {}", str);
}
}
diff --git
a/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/bloom/TestBucketizedBloomCheckPartitioner.java
b/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/bloom/TestBucketizedBloomCheckPartitioner.java
index e2929704514c..0d4f137e2566 100644
---
a/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/bloom/TestBucketizedBloomCheckPartitioner.java
+++
b/hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/index/bloom/TestBucketizedBloomCheckPartitioner.java
@@ -41,6 +41,7 @@ import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
public class TestBucketizedBloomCheckPartitioner {
+
private static Stream<Arguments> partitioningTestCases() {
// Case 1
Map<HoodieFileGroupId, Long> fileToComparisons =
constructFileToComparisons(
@@ -51,7 +52,7 @@ public class TestBucketizedBloomCheckPartitioner {
// partitioning based on parallelism of 4
Map<HoodieFileGroupId, List<Integer>> partitioning1 =
constructPartitioning(
Pair.of(new HoodieFileGroupId("p1", "f1"), new Integer[] {0, 0, 3}),
- Pair.of(new HoodieFileGroupId("p1", "f2"), new Integer[] {2, 2, 3, 1}),
+ Pair.of(new HoodieFileGroupId("p1", "f2"), new Integer[] {1, 2, 2, 1}),
Pair.of(new HoodieFileGroupId("p1", "f3"), new Integer[] {1, 0})
);
List<LookUpKeyAndResult> lookUpKeyAndResults1 =
constructLookUpKeyAndResults(
@@ -137,7 +138,7 @@ public class TestBucketizedBloomCheckPartitioner {
assertEquals(expectedPartitioning.size(), actualPartitioning.size());
for (HoodieFileGroupId id : actualPartitioning.keySet()) {
assertTrue(expectedPartitioning.containsKey(id));
- assertArrayEquals(expectedPartitioning.get(id).toArray(),
expectedPartitioning.get(id).toArray());
+ assertArrayEquals(expectedPartitioning.get(id).toArray(),
actualPartitioning.get(id).toArray());
}
lookUpKeyAndResults.forEach(lookUpKeyAndResult ->
assertEquals(lookUpKeyAndResult.expectedPartitionId,
partitioner.getPartition(