rahil-c commented on code in PR #17916:
URL: https://github.com/apache/hudi/pull/17916#discussion_r2705937066
##########
hudi-hadoop-common/src/main/java/org/apache/hudi/io/lance/HoodieBaseLanceWriter.java:
##########
@@ -52,43 +50,47 @@
@NotThreadSafe
public abstract class HoodieBaseLanceWriter<R> implements Closeable {
/** Memory size for data write operations: 120MB */
- private static final long LANCE_DATA_ALLOCATOR_SIZE = 120 * 1024 * 1024;
+ private static final long LANCE_DATA_ALLOCATOR_SIZE = 120 * 1024 * 1024L;
protected static final int DEFAULT_BATCH_SIZE = 1000;
- protected final HoodieStorage storage;
- protected final StoragePath path;
- protected final BufferAllocator allocator;
- protected final List<R> bufferedRecords;
- protected final int batchSize;
+ private final StoragePath path;
+ private final BufferAllocator allocator;
+ private final int batchSize;
+ /**
+ * -- GETTER --
Review Comment:
[nit] Do we need this comment here? Or is the @Getter annotation already and
field name already self explanatory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
