lw309637554 edited a comment on pull request #2196:
URL: https://github.com/apache/hudi/pull/2196#issuecomment-757504672


   > @lw309637554 sounds good. but I think we should have made this 
configurable and make the old behavior the default. 
`spark.write...mode("overwrite")` is a very common operation, and I'd prefer to 
not have this dependent on such new feature. Do you have cycles to do this in 
the next few hours? Please let me know. @n3nash can you drive this otherwise?
   > 
   > general rule of thumb: new features should be guarded by a flag, turned 
off by default, until deemed stable after release. :) lets please uphold this. 
Happy to discuss more if needed.
   
   @vinothchandar okay, i can add the configure now. Will land it in 
https://github.com/apache/hudi/pull/2428  cc @n3nash 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to