voonhous commented on code in PR #17953:
URL: https://github.com/apache/hudi/pull/17953#discussion_r2712515705
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/BufferedRecordMergerFactory.java:
##########
@@ -249,7 +249,7 @@ public BufferedRecord<T> finalMerge(BufferedRecord<T>
olderRecord, BufferedRecor
Comparable oldOrderingValue = olderRecord.getOrderingValue();
HoodieSchema newSchema =
recordContext.getSchemaFromBufferRecord(newerRecord);
if (!olderRecord.isCommitTimeOrderingDelete()
- && oldOrderingValue.compareTo(newOrderingValue) > 0) {
+ && OrderingValues.compare(oldOrderingValue, newOrderingValue) > 0) {
Review Comment:
Ignore the above exception in
https://github.com/apache/hudi/issues/17938#issuecomment-3776309973.
The issue was because `MercifulJsonToRowConverter extends
MercifulJsonConverter`. It inherited the `Utf8` conversion causing other paths
to throw the error we see.
Overriding it again in `MercifulJsonToRowConverter` to produce the correct
String type worked again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
