voonhous commented on issue #17978:
URL: https://github.com/apache/hudi/issues/17978#issuecomment-3783878377
#### Before Our Fix
1. `combineProperties()` -> properties WITHOUT `sourceOrderingFields`
2. `HoodieStreamer` constructor
3. `StreamSyncService` constructor
- H`oodieWriterUtils.validateTableConfig()` -> NO conflict (ordering
fields not in props)
4. `StreamSync.getHoodieClientConfig()` runs
- Validates `cfg.sourceOrderingFields` vs `tableConfig`
- Throws `HoodieValidationException`
#### After Our Fix
1. `combineProperties()` -> properties WITH `sourceOrderingFields`
2. `HoodieStreamer` constructor
3. `StreamSyncService` constructor
- `HoodieWriterUtils.validateTableConfig()` -> CONFLICT detected
- Throws `HoodieException` (earlier, different type)
4. `StreamSync.getHoodieClientConfig()` -> NEVER REACHED
TODO: We might need to check if validation that throws
`HoodieValidationException` in `StreamSync.getHoodieClientConfig` is still
required. Code snippet provided below:
https://github.com/apache/hudi/blob/0c3e7638186ad3a1b95bbe83061b0aaee9c30f85/hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java#L1171-L1174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
