TheR1sing3un commented on code in PR #17987:
URL: https://github.com/apache/hudi/pull/17987#discussion_r2720584104
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -85,6 +85,10 @@ private static boolean deleteFileAndGetResult(HoodieStorage
storage, String dele
} catch (FileNotFoundException fio) {
// With cleanPlan being used for retried cleaning operations, its
possible to clean a file twice
return false;
+ } catch (IOException e) {
+ // Wrap and rethrow
+ log.error("Delete file failed: {}", deletePath, e);
Review Comment:
> can we throw only if the file does not exist, like what we do here:
>
>
https://github.com/apache/hudi/blob/d272d283658f5dc124f144c52ee7adc02b848db5/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java#L765
sorry, I don't quite understand what you mean here. The current logic should
be basically consistent with the one you quoted.
![Uploading image.png…]()
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -85,6 +85,10 @@ private static boolean deleteFileAndGetResult(HoodieStorage
storage, String dele
} catch (FileNotFoundException fio) {
// With cleanPlan being used for retried cleaning operations, its
possible to clean a file twice
return false;
+ } catch (IOException e) {
+ // Wrap and rethrow
+ log.error("Delete file failed: {}", deletePath, e);
Review Comment:
> can we throw only if the file does not exist, like what we do here:
>
>
https://github.com/apache/hudi/blob/d272d283658f5dc124f144c52ee7adc02b848db5/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java#L765
sorry, I don't quite understand what you mean here. The current logic should
be basically consistent with the one you quoted.
<img width="1973" height="592" alt="image"
src="https://github.com/user-attachments/assets/59148950-cbbc-4ac0-bc18-6c16c5793ab9";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
