cshuo commented on code in PR #17847:
URL: https://github.com/apache/hudi/pull/17847#discussion_r2730652938
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -701,7 +702,7 @@ private Stream<HoodieBaseFile>
getLatestBaseFilesBeforeOrOnFromCache(String part
return fetchAllStoredFileGroups(partitionPath)
.filter(fileGroup ->
!isFileGroupReplacedBeforeOrOn(fileGroup.getFileGroupId(), maxCommitTime))
.map(fileGroup -> Option.fromJavaOptional(fileGroup.getAllBaseFiles()
- .filter(baseFile ->
HoodieTimeline.compareTimestamps(baseFile.getCommitTime(),
HoodieTimeline.LESSER_THAN_OR_EQUALS, maxCommitTime
+ .filter(baseFile -> compareTimestamps(baseFile.getCommitTime(),
HoodieTimeline.LESSER_THAN_OR_EQUALS, maxCommitTime
Review Comment:
ditto
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -718,7 +719,7 @@ public final Option<HoodieBaseFile> getBaseFileOn(String
partitionStr, String in
return Option.empty();
} else {
return fetchHoodieFileGroup(partitionPath, fileId).map(fileGroup ->
fileGroup.getAllBaseFiles()
- .filter(baseFile ->
HoodieTimeline.compareTimestamps(baseFile.getCommitTime(),
HoodieTimeline.EQUALS,
+ .filter(baseFile ->
compareTimestamps(baseFile.getCommitTime(), HoodieTimeline.EQUALS,
Review Comment:
ditto
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -254,7 +255,7 @@ private void resetFileGroupsReplaced(HoodieTimeline
timeline) {
// Duplicate key error when insert_overwrite same partition in multi
writer, keep the instant with greater timestamp when the file group id conflicts
Map<HoodieFileGroupId, HoodieInstant> replacedFileGroups =
resultStream.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue,
- (instance1, instance2) ->
HoodieTimeline.compareTimestamps(instance1.getTimestamp(),
HoodieTimeline.LESSER_THAN, instance2.getTimestamp()) ? instance2 : instance1));
+ (instance1, instance2) -> compareTimestamps(instance1.getTimestamp(),
HoodieTimeline.LESSER_THAN, instance2.getTimestamp()) ? instance2 : instance1));
Review Comment:
unnecessary change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
