nsivabalan commented on code in PR #17859:
URL: https://github.com/apache/hudi/pull/17859#discussion_r2733920352
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieROTablePathFilter.java:
##########
@@ -192,10 +216,10 @@ public boolean accept(Path path) {
// which contains old version files, if not specify this value,
these files will be filtered.
fsView =
FileSystemViewManager.createInMemoryFileSystemViewWithTimeline(engineContext,
metaClient, HoodieInputFormatUtils.buildMetadataConfig(conf),
-
metaClient.getActiveTimeline().filterCompletedInstants().findInstantsBeforeOrEquals(timestampAsOf));
+ completedTimeline.findInstantsBeforeOrEquals(timestampAsOf));
} else {
- fsView =
FileSystemViewManager.createInMemoryFileSystemView(engineContext,
Review Comment:
```
public static HoodieTableFileSystemView createInMemoryFileSystemView(
HoodieEngineContext engineContext, HoodieTableMetaClient metaClient,
HoodieMetadataConfig metadataConfig) {
return createInMemoryFileSystemViewWithTimeline(engineContext,
metaClient, metadataConfig,
metaClient.getActiveTimeline().getCommitsTimeline().filterCompletedInstants());
}
```
I see we are using commits timeline here.
https://github.com/apache/hudi/blob/9a988c2487369e6eca42579425e0be445a427c0e/hudi-common/src/main/java/org/apache/hudi/common/table/view/FileSystemViewManager.java#L199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
