vinothchandar commented on a change in pull request #2428:
URL: https://github.com/apache/hudi/pull/2428#discussion_r555203377
##########
File path:
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -340,6 +333,12 @@ private[hudi] object HoodieSparkSqlWriter {
if (operation != WriteOperationType.DELETE) {
if (mode == SaveMode.ErrorIfExists && tableExists) {
throw new HoodieException(s"hoodie table at $tablePath already
exists.")
+ } else if (mode == SaveMode.Overwrite && tableExists && operation !=
WriteOperationType.INSERT_OVERWRITE_TABLE) {
Review comment:
this is inline with
https://github.com/apache/hudi/blob/b6d363c0d4a6906ef1c9ea54c0263c6b5915e0b6/hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala#L301
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
