xushiyan commented on code in PR #18009:
URL: https://github.com/apache/hudi/pull/18009#discussion_r2734954848
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/source/split/TestHoodieSourceSplitSerializer.java:
##########
@@ -49,6 +49,7 @@ public void testSerializeAndDeserializeBasicSplit() throws
IOException {
"/table/path",
"/partition/path",
"read_optimized",
+ "",
Review Comment:
source split comparator rejects empty `""`, but test cases are using it. it
looks confusing as it's seen as an invalid commit time, though it may not
affect the tests that aren't for comparison. use a valid commit time to avoid
confusion and keep it consistent, you can use something like
`19700101000000000` or `0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
