prashantwason commented on PR #17777:
URL: https://github.com/apache/hudi/pull/17777#issuecomment-3813438652
Addressed all review comments:
1. **ConfigProperty**: Moved config to
`HoodieStreamerConfig.TRANSFORMED_ROW_NULLABLE` as a proper
`ConfigProperty<Boolean>`
2. **Alternative key**: Added
`hoodie.deltastreamer.transformed.row.nullable` as an alternative for backwards
compatibility
3. **Tests**: Added 3 unit tests in `TestUtilHelpers.java`:
- `testExtractSchemaFromDatasetWithNullableDisabled()` - verifies default
behavior
- `testExtractSchemaFromDatasetWithNullableEnabled()` - verifies nullable
conversion works
- `testExtractSchemaFromDatasetWithAlternativeKey()` - verifies the
deprecated deltastreamer key also works
@nsivabalan please review when you have a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
