nsivabalan commented on code in PR #17945:
URL: https://github.com/apache/hudi/pull/17945#discussion_r2738286343
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -580,8 +586,13 @@ public O postWrite(HoodieWriteMetadata<O> result, String
instantTime, HoodieTabl
result.getWriteStats().get().size());
}
- postCommit(hoodieTable, result.getCommitMetadata().get(), instantTime,
Option.empty());
- mayBeCleanAndArchive(hoodieTable);
+ HoodieTimer postWriteTimer = HoodieTimer.start();
+ try {
+ postCommit(hoodieTable, result.getCommitMetadata().get(), instantTime,
Option.empty());
Review Comment:
in L 284 ish, we are not including `postcommit` in the `postWriteTimer`. but
here, we seemed to include it.
can we remove the `postCommit` from `postWriteTimer`
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -278,8 +279,13 @@ public boolean commitStats(String instantTime,
TableWriteStats tableWriteStats,
// trigger clean and archival.
// Each internal call should ensure to lock if required.
- mayBeCleanAndArchive(table);
- runTableServicesInline(table, metadata, extraMetadata);
+ HoodieTimer postWriteTimer = HoodieTimer.start();
+ try {
+ mayBeCleanAndArchive(table);
+ runTableServicesInline(table, metadata, extraMetadata);
+ } finally {
+
metrics.updatePostWriteOperationsDurationMetrics(postWriteTimer.endTimer());
Review Comment:
`updateInlineTableServiceDurationMetrics`
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -278,8 +279,13 @@ public boolean commitStats(String instantTime,
TableWriteStats tableWriteStats,
// trigger clean and archival.
// Each internal call should ensure to lock if required.
- mayBeCleanAndArchive(table);
- runTableServicesInline(table, metadata, extraMetadata);
+ HoodieTimer postWriteTimer = HoodieTimer.start();
Review Comment:
post write somehow feels like wrapping up the commit or write. for eg,
closing or freeing up resources etc.
how about `inlineTableServicesTimer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
