the-other-tim-brown commented on code in PR #17952:
URL: https://github.com/apache/hudi/pull/17952#discussion_r2741893103
##########
hudi-common/src/main/java/org/apache/hudi/common/schema/HoodieSchema.java:
##########
@@ -96,11 +98,22 @@ public class HoodieSchema implements Serializable {
* @throws IllegalArgumentException if avroSchema is null
*/
private HoodieSchema(Schema avroSchema) {
+ this(avroSchema, null);
+ }
+
+ /**
+ * Creates a new HoodieSchema with the given Avro schema and fields.
+ * @param avroSchema the Avro schema to wrap, cannot be null
+ * @param fields the list of HoodieSchemaField objects, can be null
+ * @throws IllegalArgumentException if avroSchema is null
+ */
+ private HoodieSchema(Schema avroSchema, List<HoodieSchemaField> fields) {
Review Comment:
Yes we have `TestHoodieSchema#testCreateRecordWithEmptyList`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
