linliu-code commented on code in PR #17601:
URL: https://github.com/apache/hudi/pull/17601#discussion_r2742855372
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkParquetReader.java:
##########
@@ -55,13 +58,18 @@
import static org.apache.hudi.common.util.TypeUtils.unsafeCast;
import static
org.apache.parquet.avro.AvroSchemaConverter.ADD_LIST_ELEMENT_RECORDS;
+import static
org.apache.parquet.avro.HoodieAvroParquetSchemaConverter.getAvroSchemaConverter;
public class HoodieSparkParquetReader implements HoodieSparkFileReader {
+ public static final String ENABLE_LOGICAL_TIMESTAMP_REPAIR =
"spark.hudi.logicalTimestampField.repair.enable";
private final StoragePath path;
private final HoodieStorage storage;
private final FileFormatUtils parquetUtils;
- private List<ParquetReaderIterator> readerIterators = new ArrayList<>();
+ private final List<ClosableIterator> readerIterators = new ArrayList<>();
Review Comment:
Wait, we are adding the `final` keyword, not removing it. this should make
the `readerIterators` safer, right?
Anyways, we can remove it to reduce impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
