prashantwason commented on code in PR #18045:
URL: https://github.com/apache/hudi/pull/18045#discussion_r2743965057


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -779,6 +779,18 @@ public class HoodieWriteConfig extends HoodieConfig {
       .withDocumentation("When table is upgraded from pre 0.12 to 0.12, we 
check for \"default\" partition and fail if found one. "
           + "Users are expected to rewrite the data in those partitions. 
Enabling this config will bypass this validation");
 
+  /**
+   * Config that determines whether to block writes when Spark speculative 
execution is enabled.
+   */
+  public static final ConfigProperty<Boolean> 
BLOCK_WRITES_ON_SPECULATIVE_EXECUTION = ConfigProperty

Review Comment:
   If we are absolutely sure that HUDI does not work with speculative execution 
then yes, we dont need the config. This is the determination we need to make. 
In that case we would also need to update the docs somewhere to point this out.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to