xushiyan commented on code in PR #18022:
URL: https://github.com/apache/hudi/pull/18022#discussion_r2744050337


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java:
##########
@@ -440,6 +440,12 @@ public class FlinkOptions extends HoodieConfig {
           + "the avg read splits number per-second would be 
'read.splits.limit'/'read.streaming.check-interval', by "
           + "default no limit");
 
+  public static final ConfigOption<Boolean> READ_NEW_SOURCE_ENABLED = 
ConfigOptions
+      .key("read.new-source.enabled")
+      .booleanType()
+      .defaultValue(false)
+      .withDescription("Whether to use Flink FLIP27 new source to consume data 
files.");

Review Comment:
   calling it "new" does not convey the api in a meaningful way. what is old? 
can new always be new? pls just match it to whatever flink codebase calls it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to