danny0405 commented on code in PR #18016:
URL: https://github.com/apache/hudi/pull/18016#discussion_r2748980356


##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieReplaceCommitMetadata.java:
##########
@@ -82,6 +85,12 @@ public String toJsonString() throws IOException {
     return 
JsonUtils.getObjectMapper().writerWithDefaultPrettyPrinter().writeValueAsString(this);
   }
 
+  @Override
+  public Set<String> getWritePartitionPathsWithExistingFileGroupsModified() {
+    return 
Stream.concat(super.getWritePartitionPathsWithExistingFileGroupsModified().stream(),

Review Comment:
   is the `getPartitionToReplaceFileIds().keySet()` already enough, the 
clustering new files and it's replaced file groups are located under the same 
partition right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to