danny0405 commented on code in PR #18035:
URL: https://github.com/apache/hudi/pull/18035#discussion_r2752417833
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -83,8 +83,10 @@ private static boolean deleteFileAndGetResult(HoodieStorage
storage, String dele
}
return deleteResult;
} catch (FileNotFoundException fio) {
- // With cleanPlan being used for retried cleaning operations, its
possible to clean a file twice
- return false;
+ // With cleanPlan being used for retried cleaning operations, its
possible to clean a file twice if a file to be
Review Comment:
> My take is that, we can return true in L89, but we don't need the fixes in
HoodieTableMetadataUtil.
Looks reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]