CTTY commented on code in PR #17823:
URL: https://github.com/apache/hudi/pull/17823#discussion_r2756448999
##########
hudi-utilities/pom.xml:
##########
@@ -230,6 +230,12 @@
<artifactId>log4j-1.2-api</artifactId>
</dependency>
+ <!-- Lombok -->
+ <dependency>
+ <groupId>org.projectlombok</groupId>
+ <artifactId>lombok</artifactId>
Review Comment:
should this be provided?
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCompactor.java:
##########
@@ -196,37 +196,37 @@ public static void main(String[] args) {
if (ret != 0) {
throw new HoodieException("Fail to run compaction for " + cfg.tableName
+ ", return code: " + ret);
}
- LOG.info("Success to run compaction for " + cfg.tableName);
+ log.info("Success to run compaction for {}", cfg.tableName);
jsc.stop();
}
public int compact(int retry) {
this.fs = HadoopFSUtils.getFs(cfg.basePath, jsc.hadoopConfiguration());
// need to do validate in case that users call compact() directly without
setting cfg.runningMode
validateRunningMode(cfg);
- LOG.info(cfg.toString());
+ log.info(cfg.toString());
int ret = UtilHelpers.retry(retry, () -> {
switch (cfg.runningMode.toLowerCase()) {
case SCHEDULE: {
- LOG.info("Running Mode: [" + SCHEDULE + "]; Do schedule");
+ log.info("Running Mode: [{}] Do schedule", SCHEDULE);
Option<String> instantTime = doSchedule(jsc);
int result = instantTime.isPresent() ? 0 : -1;
if (result == 0) {
- LOG.info("The schedule instant time is " + instantTime.get());
+ log.info("The schedule instant time is {}", instantTime.get());
}
return result;
}
case SCHEDULE_AND_EXECUTE: {
- LOG.info("Running Mode: [" + SCHEDULE_AND_EXECUTE + "]");
+ log.info("Running Mode: [{}]", SCHEDULE_AND_EXECUTE);
return doScheduleAndCompact(jsc);
}
case EXECUTE: {
- LOG.info("Running Mode: [" + EXECUTE + "]; Do compaction");
+ log.info("Running Mode: [" + EXECUTE + "]; Do compaction");
Review Comment:
```suggestion
log.info("Running Mode: [{}]; Do compaction", EXECUTE);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
