nsivabalan commented on PR #17604:
URL: https://github.com/apache/hudi/pull/17604#issuecomment-3843886690
hey @PavithranRick :
can you revisit the PR description and fix it to whats the latest state of
the patch.
for eg:
```
If `enablePartialEncoding` is `true`, the provided `PartialUpdateMode` will
be honored.
**Interaction between table property and Merge Into encoding:**
| Merge Mode | Table Property: hoodie.table.partial.update.mode | Writer
| BufferedRecordMerger: enablePartialEncoding | BufferedRecordMerger:
Option<PartialUpdateMode> |
|------------|--------------------------------------------------|-------------|---------------------------------------------|--------------------------------------------------|
| event time | not set | spark-ds
| false | Option.empty()
|
| event time | not set | Merge Into
| true | KEEP_VALUES
|
| event time | IGNORE_DEFAULTS | spark-ds
| true | IGNORE_DEFAULTS
|
| event time | IGNORE_DEFAULTS | Merge Into
| true | IGNORE_DEFAULTS
|
**Pending:**
- Unless we land get the fix landed for
https://issues.apache.org/jira/browse/HUDI-9638 these new PartialUpdateModes
are not taking effect for end to end functional tests.
- Also, we need to add more tests directly against BufferedRecordMerger
class.
```
these might need to be cleaned up. and Pending section has to revisited.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
