CTTY commented on code in PR #17878:
URL: https://github.com/apache/hudi/pull/17878#discussion_r2761634671
##########
hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java:
##########
@@ -385,6 +381,8 @@ public long getTimestamp() {
/**
* The value relevant metadata.
*/
+ @AllArgsConstructor(access = AccessLevel.PRIVATE)
Review Comment:
The original ctor was `protected`. is this correct?
##########
hudi-common/src/main/java/org/apache/hudi/common/util/RocksDBSchemaHelper.java:
##########
@@ -49,6 +52,7 @@ public class RocksDBSchemaHelper {
private final String colFamilyForBootstrapBaseFile;
private final String colFamilyForStoredPartitions;
private final String colFamilyForReplacedFileGroups;
+ @Getter
Review Comment:
We don't need this since we already have class-level `Getter`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
