danny0405 commented on code in PR #18018:
URL: https://github.com/apache/hudi/pull/18018#discussion_r2762064386
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/index/RecordIndexCache.java:
##########
@@ -30,31 +30,45 @@
import org.apache.hudi.util.FlinkWriteClients;
import lombok.Getter;
+import lombok.extern.slf4j.Slf4j;
import org.apache.flink.configuration.Configuration;
import java.io.Closeable;
import java.io.IOException;
-import java.util.Collections;
import java.util.Comparator;
import java.util.NavigableMap;
import java.util.TreeMap;
+import static
org.apache.hudi.common.util.collection.ExternalSpillableMap.SIZING_FACTOR_FOR_IN_MEMORY_MAP;
+
/**
* Cache to hold the in-flight record level index entries which are not
committed to metadata table yet.
* <p>
* todo: use map backed by flink managed memory.
*/
+@Slf4j
public class RecordIndexCache implements Closeable {
@VisibleForTesting
@Getter
private final TreeMap<Long, ExternalSpillableMap<String,
HoodieRecordGlobalLocation>> caches;
private final HoodieWriteConfig writeConfig;
+ @VisibleForTesting
+ @Getter
private final long maxCacheSizeInBytes;
+ // the minimum checkpoint id for the inflight hoodie instant.
+ private long minRetainedCheckpointId;
Review Comment:
the minimum checkpoint id for the inflight hoodie instant to be retained
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
