linliu-code commented on code in PR #17834:
URL: https://github.com/apache/hudi/pull/17834#discussion_r2762102073
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/ComplexKeyGenerator.java:
##########
@@ -47,6 +48,7 @@ public ComplexKeyGenerator(TypedProperties props) {
.filter(s -> !s.isEmpty())
.collect(Collectors.toList());
this.complexAvroKeyGenerator = new ComplexAvroKeyGenerator(props);
+ this.encodeSingleKeyFieldName =
KeyGenUtils.encodeSingleKeyFieldNameForComplexKeyGen(props);
Review Comment:
Does line 46: props.getString() throw null when `PARTITIONPATH_FIELD_NAME`
is missing? If so, NPE could be thrown when accessing .split() function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
