nsivabalan commented on code in PR #17942:
URL: https://github.com/apache/hudi/pull/17942#discussion_r2765848416
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/prometheus/TestPrometheusReporter.java:
##########
@@ -74,9 +74,13 @@ void setUp() {
@AfterEach
void shutdownMetrics() {
if (metrics != null) {
- metrics.shutdown();
+ try {
+ metrics.shutdown();
+ } catch (Exception e) {
+ log.debug("Exception during metrics shutdown: {}", e.getMessage());
Review Comment:
why not log.error?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieCleanConfig.java:
##########
@@ -201,6 +201,16 @@ public class HoodieCleanConfig extends HoodieConfig {
+ "table receives updates/deletes. Another reason to turn this on,
would be to ensure data residing in bootstrap "
+ "base files are also physically deleted, to comply with data
privacy enforcement processes.");
+ public static final ConfigProperty<Boolean>
USE_LOCAL_ENGINE_FOR_METADATA_NON_PARTITIONED_DATASETS = ConfigProperty
Review Comment:
I don't see a necessity for anyone to do this for partitioned data tables.
So, can we name this
`hoodie.clean.optimize.using.local.engine.context"
and make default as true.
programmatically, we can employ this only for non partitioned and metadata
table.
if for some reason, users do not want that, they can disable via this
config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
