cshuo commented on code in PR #18082: URL: https://github.com/apache/hudi/pull/18082#discussion_r2767685471
########## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/assign/DefaultHoodieSplitAssigner.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.source.assign; + +import org.apache.flink.runtime.state.KeyGroupRangeAssignment; +import org.apache.hudi.source.split.HoodieSourceSplit; + +/** + * Default implementation of {@link HoodieSplitAssigner} that assigns Hoodie + * source splits to task IDs by hashing the file ID. + */ +public class DefaultHoodieSplitAssigner implements HoodieSplitAssigner { + private final int parallelism; + + /** + * Creates a new DefaultHoodieSplitAssigner. + * + * @param parallelism the number of parallel tasks (must be positive) + * @throws IllegalArgumentException if parallelism is less than or equal to 0 + */ + public DefaultHoodieSplitAssigner(int parallelism) { + if (parallelism <= 0) { + throw new IllegalArgumentException("Parallelism must be positive, but was: " + parallelism); + } + this.parallelism = parallelism; + } + + @Override + public int assign(HoodieSourceSplit split) { + int maxParallelism = KeyGroupRangeAssignment.computeDefaultMaxParallelism(parallelism); Review Comment: `maxParallelism` can be moved as a class field, and initialized only once. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
