prashantwason commented on PR #17774:
URL: https://github.com/apache/hudi/pull/17774#issuecomment-3855743052

   Closing this PR as the changes have already been incorporated into master 
through other commits.
   
   After rebasing to latest apache/master, I verified that:
   - `candidateRecordKeys` is already `Set<String>` with `HashSet` 
initialization
   - `filterKeysFromFile` already accepts `Set<String>` parameter
   - The return type is `Collection<Pair<String, Long>>` which is more generic 
than `List`
   
   The core optimization (using Set instead of ArrayList to reduce memory 
overhead) is already in place.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to