nsivabalan commented on code in PR #18091:
URL: https://github.com/apache/hudi/pull/18091#discussion_r2771072192
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -644,14 +644,14 @@ private void doCommit(long checkpointId, String instant,
List<WriteStatus> dataW
log.error("The first 10 files with write errors:");
dataWriteResults.stream().filter(WriteStatus::hasErrors).limit(10).forEach(ws
-> {
if (ws.getGlobalError() != null) {
- log.error("Global error for partition path {} and fileID {}: {}",
+ log.error("Global error for partition path {} and fileID {}:",
Review Comment:
can we add an empty space(` `) after `:`
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -644,14 +644,14 @@ private void doCommit(long checkpointId, String instant,
List<WriteStatus> dataW
log.error("The first 10 files with write errors:");
dataWriteResults.stream().filter(WriteStatus::hasErrors).limit(10).forEach(ws
-> {
if (ws.getGlobalError() != null) {
- log.error("Global error for partition path {} and fileID {}: {}",
+ log.error("Global error for partition path {} and fileID {}:",
ws.getPartitionPath(), ws.getFileId(), ws.getGlobalError());
}
if (!ws.getErrors().isEmpty()) {
log.error("The first 100 records-level errors for partition path {}
and fileID {}:",
ws.getPartitionPath(), ws.getFileId());
ws.getErrors().entrySet().stream().limit(100).forEach(entry ->
- log.error("Error for key: {} and Exception: {}", entry.getKey(),
entry.getValue().getMessage()));
+ log.error("Error for key {}:", entry.getKey(),
entry.getValue()));
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
