prashantwason commented on PR #18047: URL: https://github.com/apache/hudi/pull/18047#issuecomment-3856874169
Responding to @danny0405's comment about the removed exception handling: Good catch. The `FSUtils.getAllDataFilesInPartition()` method already handles `FileNotFoundException` by returning an empty list (see FSUtils.java L493-496), which covers the main case where the partition doesn't exist. The original code had broader `IOException` handling with retry logic for the "partition created by another caller" race condition. However: 1. `FileNotFoundException` should be the specific exception thrown when listing a non-existent partition 2. If another type of `IOException` occurs (e.g., permission issues, network errors), propagating it rather than silently retrying seems more appropriate 3. The retry logic in the original code doesn't actually handle transient errors properly - if the same error occurs on retry, it would still propagate That said, if you'd like me to preserve the retry semantics for the race condition case, I can add that handling. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
