danny0405 commented on a change in pull request #2430:
URL: https://github.com/apache/hudi/pull/2430#discussion_r557013794
##########
File path: hudi-flink/src/main/java/org/apache/hudi/util/StreamerUtil.java
##########
@@ -245,10 +247,9 @@ public static TypedProperties
flinkConf2TypedProperties(Configuration conf) {
}
public static void checkRequiredProperties(TypedProperties props,
List<String> checkPropNames) {
- checkPropNames.forEach(prop -> {
- if (!props.containsKey(prop)) {
- throw new HoodieNotSupportedException("Required property " + prop + "
is missing");
- }
- });
+ checkPropNames.forEach(prop ->
+ Preconditions.checkState(
Review comment:
Personally i prefer shorter line code. Refactoring it if Hoodie thinks
long line code is ok.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
