the-other-tim-brown commented on code in PR #18007:
URL: https://github.com/apache/hudi/pull/18007#discussion_r2774744048
##########
hudi-common/src/main/java/org/apache/hudi/avro/AvroSchemaUtils.java:
##########
@@ -336,17 +136,4 @@ public static Schema asNullable(Schema schema) {
(change, field) -> change.updateColumnNullability(field, true));
return convert(SchemaChangeUtils.applyTableChanges2Schema(internalSchema,
schemaChange), schema.getFullName()).toAvroSchema();
}
-
- /**
- * Helper to copy properties and logical types from source schema to target
schema.
- */
- private static Schema copyProperties(Schema source, Schema target) {
- for (Map.Entry<String, Object> prop : source.getObjectProps().entrySet()) {
- target.addProp(prop.getKey(), prop.getValue());
- }
- if (source.getLogicalType() != null) {
- source.getLogicalType().addToSchema(target);
- }
Review Comment:
The logical type information is stored as a properties so this is redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
