yihua commented on code in PR #18043:
URL: https://github.com/apache/hudi/pull/18043#discussion_r2775593759


##########
hudi-common/src/main/java/org/apache/hudi/common/schema/HoodieSchema.java:
##########
@@ -864,7 +863,7 @@ public Map<String, Object> getObjectProps() {
    * @return the property value, or null if not found
    */
   public Object getProp(String key) {
-    return avroSchema.getProp(key);
+    return avroSchema.getObjectProps().get(key);

Review Comment:
   `Schema#getObjectProps` instantiates a new Map.  Should this use 
`Schema#getObjectProp` so that it avoids the overhead while handling all types 
properly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to