yihua commented on code in PR #18104:
URL: https://github.com/apache/hudi/pull/18104#discussion_r2776484162
##########
hudi-aws/src/main/java/org/apache/hudi/aws/transaction/lock/DynamoDBBasedImplicitPartitionKeyLockProvider.java:
##########
@@ -56,12 +56,9 @@ public DynamoDBBasedImplicitPartitionKeyLockProvider(
@Override
public String getDynamoDBPartitionKey(LockConfiguration lockConfiguration) {
- // Ensure consistent format for S3 URI.
- String hudiTableBasePathNormalized =
s3aToS3(lockConfiguration.getConfig().getString(
- HoodieCommonConfig.BASE_PATH.key()));
Review Comment:
This method is invoked in the constructor of super class,
`DynamoDBBasedLockProviderBase`, where the member variable `hudiTableBasePath`
is not yet initialized. Have you validated that it actually works?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
