voonhous commented on code in PR #17825:
URL: https://github.com/apache/hudi/pull/17825#discussion_r2778417355
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/TestCleaner.java:
##########
@@ -715,18 +715,30 @@ public void testCleanMetadataUpgradeDowngrade() {
List<String> failedDeleteFiles1 = Collections.singletonList(filePath2);
// create partition1 clean stat.
- HoodieCleanStat cleanStat1 = new
HoodieCleanStat(HoodieCleaningPolicy.KEEP_LATEST_FILE_VERSIONS,
- partition1, deletePathPatterns1, successDeleteFiles1,
- failedDeleteFiles1, instantTime, "");
+ HoodieCleanStat cleanStat1 = HoodieCleanStat.builder()
+ .withPolicy(HoodieCleaningPolicy.KEEP_LATEST_FILE_VERSIONS)
+ .withPartitionPath(partition1)
+ .withDeletePathPatterns(deletePathPatterns1)
+ .withSuccessDeleteFiles(successDeleteFiles1)
+ .withFailedDeleteFiles(failedDeleteFiles1)
+ .withEarliestCommitToRetain(instantTime)
+ .withLastCompletedCommitTimestamp("")
+ .build();
List<String> deletePathPatterns2 = new ArrayList<>();
List<String> successDeleteFiles2 = new ArrayList<>();
List<String> failedDeleteFiles2 = new ArrayList<>();
// create partition2 empty clean stat.
- HoodieCleanStat cleanStat2 = new
HoodieCleanStat(HoodieCleaningPolicy.KEEP_LATEST_COMMITS,
- partition2, deletePathPatterns2, successDeleteFiles2,
- failedDeleteFiles2, instantTime, "");
+ HoodieCleanStat cleanStat2 = HoodieCleanStat.builder()
+ .withPolicy(HoodieCleaningPolicy.KEEP_LATEST_FILE_VERSIONS)
Review Comment:
Copy paste error, reverting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
