suryaprasanna commented on code in PR #17929:
URL: https://github.com/apache/hudi/pull/17929#discussion_r2784773103
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/HoodieIncrSource.java:
##########
@@ -288,6 +289,12 @@ private Pair<Option<Dataset<Row>>, Checkpoint>
fetchNextBatchBasedOnCompletionTi
// add filtering so that only interested records are returned.
.filter(String.format("%s IN ('%s')",
HoodieRecord.COMMIT_TIME_METADATA_FIELD,
String.join("','", instantTimeList)));
+
+ // Calculate metrics for snapshot query
+ int numInstantsProcessed = instantTimeList.size();
+ int numUnprocessedInstants = (int) queryContext.getActiveTimeline()
+ .findInstantsAfter(endCompletionTime).countInstants();
+ metricsOption.ifPresent(metrics ->
metrics.updateHoodieIncrSourceMetrics(numInstantsProcessed,
numUnprocessedInstants));
Review Comment:
fetchNextBatchBasedOnRequestedTime uses IncrSourceHelper class. So, we are
emitting metrics from there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
