suryaprasanna commented on code in PR #17928: URL: https://github.com/apache/hudi/pull/17928#discussion_r2784861084
########## hudi-common/src/main/java/org/apache/hudi/common/model/ReverseOrderHoodieRecordPayload.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.model; + +import org.apache.avro.generic.GenericRecord; +import org.apache.hudi.common.util.Option; + +/** + * {@link HoodieRecordPayload} impl that honors ordering field in both preCombine and combineAndGetUpdateValue. + * This class extends DefaultHoodieRecordPayload implementation but overrides comparable method that determines the order. + * + * 1. preCombine - Keeps the oldest record for a key, based on an ordering field + * 2. combineAndGetUpdateValue/getInsertValue - Chooses the oldest record based on ordering field value. + */ +public class ReverseOrderHoodieRecordPayload extends DefaultHoodieRecordPayload { + + public ReverseOrderHoodieRecordPayload(GenericRecord record, Comparable orderingVal) { + super(record, orderingVal); + } + + public ReverseOrderHoodieRecordPayload(Option<GenericRecord> record) { + super(record); + } + + @Override + public OverwriteWithLatestAvroPayload preCombine(OverwriteWithLatestAvroPayload oldValue) { + if (oldValue.isEmptyRecord()) { + // use natural order for delete record + return this; + } + if (oldValue.orderingVal.compareTo(orderingVal) < 0) { + // pick the payload with the lowest ordering value + return oldValue; + } else { + return this; Review Comment: During precombine yes, but not during combineAndGetUpdateValue operation, that behavior depends on updateOnSameOrderingField value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
