rahil-c commented on PR #18146:
URL: https://github.com/apache/hudi/pull/18146#issuecomment-3875553108
> Naming. Can we do sth like this.
>
> ```
> {
> "type": "record",
> "name": "vector",
> "logicalType": "vector",
> "fields": [
> {
> "name": "numDimensions",
> "type": "int",
> "default": 1536
> },
> {
> "name": "storageEncoding",
> "type": "string",
> "default": "FLOAT_ARRAY"
> },
> {
> "name": "valuesArray",
> "type": ["null", {"type": "array", "items": "float"}],
> "default": null
> },
> {
> "name": "valuesFixed",
> "type": ["null", "bytes"],
> "default": null
> }
> ]
> }
> ```
>
> do we need a `elementType` to capture float vs double
@vinothchandar good point on elementType, I have added that now.
In terms of naming I feel like `numDimensions` is maybe redudant and
`dimension` would imply same thing? Similarly for `storageEncoding` feels
similar to `storageBacking`. If you feel strongly though I can make these
naming changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
