danny0405 commented on a change in pull request #2430:
URL: https://github.com/apache/hudi/pull/2430#discussion_r558106065
##########
File path: hudi-flink/pom.xml
##########
@@ -124,28 +124,77 @@
<artifactId>kafka-clients</artifactId>
<version>${kafka.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+
<artifactId>flink-hadoop-compatibility_${scala.binary.version}</artifactId>
+ <version>${flink.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-avro</artifactId>
+ <version>${flink.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-json</artifactId>
+ <version>${flink.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-table-common</artifactId>
+ <version>${flink.version}</version>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+
<artifactId>flink-table-runtime-blink_${scala.binary.version}</artifactId>
Review comment:
I think we should not package the in-compatible Flink jars into the
bundle, just like the guideline [1], the hudi bundle is used as a spark shell
library. Here only `spark-sql` jar are packaged into Hoodie jars.
The table jars introduced here like `flink-table-common` and
`flink-table-runtime-blink` are only used by the new pipeline, so we can
package the into the `hoodie-flink` jar, the old pipeline should not be
affected. The data stream api should be compatible itself, if the old pipeline
does not use API comes from 1.10+ version.
[1] https://hudi.apache.org/docs/quick-start-guide.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
