nsivabalan commented on code in PR #18084:
URL: https://github.com/apache/hudi/pull/18084#discussion_r2796625324
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/BaseSparkCommitActionExecutor.java:
##########
@@ -329,9 +329,18 @@ protected String getCommitActionType() {
protected void
setCommitMetadata(HoodieWriteMetadata<HoodieData<WriteStatus>> result) {
List<HoodieWriteStat> writeStats =
result.getWriteStatuses().map(WriteStatus::getStat).collectAsList();
result.setWriteStats(writeStats);
+ // Merge engine-specific metadata (e.g., spark_application_id) with extra
metadata
+ Option<Map<String, String>> mergedExtraMetadata = extraMetadata;
+ Map<String, String> engineMetadata = context.getEngineCommitMetadata();
+ if (!engineMetadata.isEmpty()) {
Review Comment:
looks like we are repeating this in many places.
can we add a static method to `CommitUtils` (this already has method to
build commit metadata), and use it across the board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
