nsivabalan commented on code in PR #18061:
URL: https://github.com/apache/hudi/pull/18061#discussion_r2796631675
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCreateRecordUtils.scala:
##########
@@ -150,11 +152,28 @@ object HoodieCreateRecordUtils {
avroRecWithoutMeta
}
val hoodieRecord = if (shouldCombine && !orderingFields.isEmpty) {
+ // Ordering values are not required for COMMIT_TIME_ORDERING or
OverwriteWithLatestAvroPayload
+ val requiresOrderingValue = recordMergeMode !=
RecordMergeMode.COMMIT_TIME_ORDERING &&
+
!classOf[OverwriteWithLatestAvroPayload].getName.equals(payloadClass)
val orderingVal = OrderingValues.create(
orderingFields,
JFunction.toJavaFunction[String, Comparable[_]](
- field => HoodieAvroUtils.getNestedFieldVal(avroRec, field,
false,
-
consistentLogicalTimestampEnabled).asInstanceOf[Comparable[_]]))
+ field => {
+ val fieldVal = HoodieAvroUtils.getNestedFieldVal(avroRec,
field, false,
Review Comment:
this is becoming too fat.
can we move this to a private method.
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieCreateRecordUtils.scala:
##########
@@ -150,11 +152,28 @@ object HoodieCreateRecordUtils {
avroRecWithoutMeta
}
val hoodieRecord = if (shouldCombine && !orderingFields.isEmpty) {
+ // Ordering values are not required for COMMIT_TIME_ORDERING or
OverwriteWithLatestAvroPayload
+ val requiresOrderingValue = recordMergeMode !=
RecordMergeMode.COMMIT_TIME_ORDERING &&
+
!classOf[OverwriteWithLatestAvroPayload].getName.equals(payloadClass)
val orderingVal = OrderingValues.create(
orderingFields,
JFunction.toJavaFunction[String, Comparable[_]](
- field => HoodieAvroUtils.getNestedFieldVal(avroRec, field,
false,
-
consistentLogicalTimestampEnabled).asInstanceOf[Comparable[_]]))
+ field => {
+ val fieldVal = HoodieAvroUtils.getNestedFieldVal(avroRec,
field, false,
Review Comment:
should we also add similar logic to spark record type as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
